Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty link opens boostnote logo #2970

Closed
arcturus140 opened this issue Apr 14, 2019 · 6 comments
Closed

empty link opens boostnote logo #2970

arcturus140 opened this issue Apr 14, 2019 · 6 comments
Labels
bug 🐛 Issue concerns a bug. rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded.

Comments

@arcturus140
Copy link
Contributor

arcturus140 commented Apr 14, 2019

Issuehunt badges

Current behavior

A minor problem, not sure if it is an issue but I thought I'd report it:

In a markdown note, when you click on an empty link it opens the following URL:
file:///usr/share/boostnote/resources/app/lib/main.html

Steps to reproduce

  1. create empty link in markdown: [link]()
  2. click on link in preview

Environment

  • Version : 0.11.12
  • OS Version and name : 16.04 Ubuntu

zerox-dg earned $30.00 by resolving this issue!

@ZeroX-DG ZeroX-DG added the bug 🐛 Issue concerns a bug. label Apr 14, 2019
@ZeroX-DG
Copy link
Member

This should be a bug. An empty link shouldn't lead to anywhere. Thanks for reporting!

@MiloTodt
Copy link
Contributor

I've been able to duplicate this issue with the current build of Boostnote 0.11.15 on Windows 10 as well.

@issuehunt-oss issuehunt-oss bot added the funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. label May 1, 2019
@IssueHuntBot
Copy link

@BoostIO has funded $30.00 to this issue.


@AWolf81
Copy link
Contributor

AWolf81 commented May 1, 2019

I first thought this is fixed but there is one point open. For an empty link the context menu will still open the file in Explorer - so adding the test && event.target.getAttribute('href') to line MarkdownPreview #258 should fix this issue.

image

@ZeroX-DG
Copy link
Member

ZeroX-DG commented May 2, 2019

Thanks @AWolf81

@issuehunt-oss issuehunt-oss bot added rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded. and removed funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. labels May 7, 2019
@IssueHuntBot
Copy link

@kazup01 has rewarded $27.00 to @ZeroX-DG. See it on IssueHunt

  • 💰 Total deposit: $30.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $3.00

@ZeroX-DG ZeroX-DG closed this as completed Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded.
Projects
None yet
Development

No branches or pull requests

5 participants