Note attachment folders are not removed when empty

[manuel-koch]

Current behavior

Creating a new note, adding one attachment file, re-edit note remove the attachment-link, attachment file in storage is removed but the parent directory is still there.

I have now several of those empty attachment folders in my storage-location.

Expected behavior

I guess the attachment-folder is per note, thus if a note has no more attachments, then I would expect that folder is removed too.

Steps to reproduce

1. Create a new note.
2. Drop a file on the note, a link is created in the note referring attachment.
3. Go to some other note.
4. Check the storage-location contains a new directory incl a copy of file that was dropped on note.
5. Go back to former note and edit it again, remove the attachment-link.
6. Leave edit mode of note and wait some time.
7. Check the storage-location, the former attachment file is removed but the parent directory still exists.

Environment

• Version : 0.12.0
• OS Version and name : MacOS 10.14.5
• Storage location is a locally synced, shared OneDrive folder