Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grave accent matching character does not work on Swedish keyboard layout #3299

Open
Menturan opened this issue Oct 22, 2019 · 6 comments
Open
Labels
needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem.

Comments

@Menturan
Copy link

Current behavior

When typing the grave accent character, it doesn't autocomplete with matching or triples.

grave_accent_boostnote

Expected behavior

Autocomplete with matching or triples grave accent characters.

Steps to reproduce

  1. Choose Swedish as your keyboard layout
  2. Make a grave accent by pressing Shift+key-to-the-left-of-backspace (plus-key on us keyboards) twice for completion with matching and or four times for completion with triples.

Theory

My theory why this doesn't work is that the grave-accent-key is on another key than on us keyboards and you have to press Shift+grave-accent-key.

Environment

  • Version : 0.13.0
  • OS Version and name : Ubuntu 18.04
@Flexo013 Flexo013 added the improvement request 🔨 Issue concerns an existing feature that needs improvement. label Oct 22, 2019
@Flexo013
Copy link
Contributor

I have the feeling that the code might be looking for the grave/backtick keypress, rather than looking at what the last character typed was. So when different keyboard layouts actually have the character somewhere else it doesn't trigger.

@arcturus140
Copy link
Contributor

arcturus140 commented Oct 22, 2019

[[Shift-L]] === [[Shift-R]]

swedish

I have the feeling that the code might be looking for the grave/backtick keypress, rather than looking at what the last character typed was.

without looking at the code I would expect the input be abstract to auto completion.

Environment

  • Version : 0.11.12
  • Version : 0.13.0
  • OS Version and name : 16.04 Ubuntu

@Flexo013 Flexo013 added needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. and removed improvement request 🔨 Issue concerns an existing feature that needs improvement. labels Oct 22, 2019
@Flexo013
Copy link
Contributor

@arcturus140 Could you check this with 0.13.0 as well? Just to make sure nothing affected this behavior between 0.11.12 and now.

@Menturan
Copy link
Author

I notice that Boostnote uses Codemirror as text editor and that there is an closebrackets.js addon that we are using for this functionality. Maybe the issue is with that addon?

@arcturus140
Copy link
Contributor

arcturus140 commented Oct 23, 2019

@Flexo013 I repeated the test, same result. FYI I am using a different keyboard but similar layout myself and never had any issues. Is there a way to log input keys in Boostnote?

Maybe system region settings make a difference?

@Menturan are you using swedish in swedish or a subtype variant, like DVORAK or Macintosh?

Do you get the same result when using

  • [[shift]] + [[ ` ]] , [[shift]] + [[ ` ]]
  • [[shift]] + [[ ` ]] , [[space]]

What is your Editor Keymap setting in Preferences / Interface?

@Menturan
Copy link
Author

@Menturan are you using swedish in swedish or a subtype variant, like DVORAK or Macintosh?

No subtype. Standard Swedish layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem.
Projects
None yet
Development

No branches or pull requests

3 participants