Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank screen when Image's url has a : character #273

Closed
michaelkrasa opened this issue Jan 9, 2020 · 6 comments · Fixed by #282
Closed

Blank screen when Image's url has a : character #273

michaelkrasa opened this issue Jan 9, 2020 · 6 comments · Fixed by #282
Labels
bug 🐛 Issue concerns a bug.

Comments

@michaelkrasa
Copy link

Current behavior

When I click to change any of the views I get a blank screen with nothing to click on.
Currently can't get out of this behavior. I can open the tutorial but when I click on my notes I get the white screen again.

Expected behavior

Changed view according to what I clicked on.

Steps to reproduce

  1. Select any note
  2. Click on any of the views (the three buttons in lower left corner)
  3. Get a blank screen

Environment

  • Version :
  • OS Version and name : Latest Win 10, issue is present on my laptop as well as my desktop PC.

@michaelkrasa
Copy link
Author

Here's a link to a youtube video where I showcase the issue.
https://youtu.be/F-02CCKdPyk

@Flexo013 Flexo013 transferred this issue from BoostIO/BoostNote-Legacy Jan 9, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Jan 9, 2020

Thanks for the reporting. I'm investigating now.

@Rokt33r
Copy link
Member

Rokt33r commented Jan 9, 2020

@Phauglin I couldn't reproduce the problem. Could you share me error messages from the dev tool? I can see there are 18 errors from your screenshots.

@Rokt33r Rokt33r added needs more info ℹ️ Issue requires more information from the issue's reporter. bug 🐛 Issue concerns a bug. labels Jan 9, 2020
@michaelkrasa
Copy link
Author

image

When I used boostnote today and didn't click those views at the bottom I was able to use it normally. I read your reply, clicked on the view and now I'm stuck on a blank screen again hm.

@Rokt33r
Copy link
Member

Rokt33r commented Jan 10, 2020

@Phauglin I confirmed the problem. It happen when Image reference's url has a : character. I'll fix it soon.

@Rokt33r Rokt33r removed the needs more info ℹ️ Issue requires more information from the issue's reporter. label Jan 10, 2020
@Rokt33r Rokt33r changed the title Blank screen when any view is selected Blank screen when Image's url has a : character Jan 10, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Jan 10, 2020

I found more information. The current app is sanitizing markdown contents by default including url of images. So the app considers your image url, storage:..., has invalid protocol, storage, rather than http or https and makes src prop of Image nodes undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants