Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add the function of exporting a markdown file as a pdf #346

Closed
Kajiyu opened this issue Mar 21, 2017 · 14 comments
Closed

Feature: Add the function of exporting a markdown file as a pdf #346

Kajiyu opened this issue Mar 21, 2017 · 14 comments
Labels
feature request 🌟 Issue is a new feature request. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!

Comments

@Kajiyu
Copy link

Kajiyu commented Mar 21, 2017

I want to export my markdown file as a pdf.

@kazup01
Copy link
Member

kazup01 commented Mar 21, 2017

Yeah it's exactly as you said. We want to add it but we have other priorities.
If possible, could you send PR to us?

@asmsuechan
Copy link
Contributor

asmsuechan commented Mar 21, 2017

Hi, @Kajiyu! I've heard it from a lot of people #133 (comment), #52, and #51. I also want it, but it's quite complicated. Perhaps it takes a while. Could you implement it?

@kazup01 kazup01 added feature request 🌟 Issue is a new feature request. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Mar 21, 2017
@Kajiyu
Copy link
Author

Kajiyu commented Mar 21, 2017

Of course😃 I'm trying it😃

@kazup01
Copy link
Member

kazup01 commented Mar 21, 2017

Great🎉

@Kajiyu
Copy link
Author

Kajiyu commented Mar 21, 2017

I tried to make an 'add pdf-export' function, but when I debug with the command grunt pre-build, the screen does not update from the initial state, like this. Do you have anything to think about?

2017-03-21 17 21 58
Also, I found this message while building app. Is 'auth_code.json' needed to debug?

secret/auth_code.json is not found. CodeSigning is not available.
Running "pre-build" task

Running "compile" task
node_modules/.bin/webpack --config webpack-production.config.js
Hash: 58bc1566479ec76dcf25
Version: webpack 1.14.0
Time: 29577ms
    Asset     Size  Chunks             Chunk Names
  main.js  1.42 MB       0  [emitted]  main
finder.js  1.03 MB       1  [emitted]  finder
    + 799 hidden modules


Running "pack:osx" (pack) task
/Users/YumaKajihara/oss/Boostnote/dist
Downloading electron-v1.2.8-darwin-x64.zip
[============================================>] 100.0% of 42.74 MB (3.98 MB/s)
Packaging app for platform darwin x64 using electron v1.2.8

This is my commit, please watch when you are free.
Kajiyu@18da79c

@asmsuechan
Copy link
Contributor

you don't need to build, could you run these commands in 2 terminals?

$ npm run webpack
$ npm run hot

@Kajiyu
Copy link
Author

Kajiyu commented Mar 21, 2017

Thank you!
When I run npm run webpack, the message 'webpack: bundle is now VALID.' is not shown, and the process has been continuing like the picture below.

2017-03-21 17 38 48

Two js files(finder.js, main.js) is built successfully.
When I run npm run hot, the same thing happens as above...

@asmsuechan
Copy link
Contributor

Debug it 😃 At least current master, Boostnote works well. I assume it's because of markdown-pdf.

@asmsuechan
Copy link
Contributor

asmsuechan commented Mar 21, 2017

An error occurs at this line, this is a node module which dependents with markdown-pdf (refs: https://github.com/alanshaw/markdown-pdf/blob/master/index.js#L8).

@asmsuechan
Copy link
Contributor

@Kajiyu What's going on?

@Gernatch
Copy link

No constructive feedback to offer. Just want to +1 on the suggestion to accomplish this goal. Also, first time speaking up here...I'm highly impressed with the direction of this software.

@asmsuechan
Copy link
Contributor

asmsuechan commented Apr 3, 2017

@Gernatch Thanks for the comment. I try to implement it.

@asmsuechan
Copy link
Contributor

@Kajiyu As also written above, this feature request is duplicated. If you won't response in a day, I'll close this issue.

@asmsuechan
Copy link
Contributor

I close because of no reaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!
Projects
None yet
Development

No branches or pull requests

4 participants