Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid hotkey crash the whole app #3501

Open
ZeroX-DG opened this issue Feb 27, 2020 · 0 comments
Open

Invalid hotkey crash the whole app #3501

ZeroX-DG opened this issue Feb 27, 2020 · 0 comments
Labels
bug 🐛 Issue concerns a bug. level 2 ❗ A bug that causes major damage: App is barely usable, since major features are not working.

Comments

@ZeroX-DG
Copy link
Member

Current behavior

CodeMirror consider the last key in the hotkey sequence is the keyname and before that are modifier keys. For example:

Ctrl    +    Shift    +    V
   |           |           |
    \         /            |
     \       /             |
     Modifier             Key 

If the hot key is set to

Ctrl + Shift + V + B
  |      |     |   |
   \     |    /    |
     \   |   /     |
      Modifier    Key

which is invalid because V is not a modifier key. This problem will crash the whole app and cause this issue to happen: #3481

Expected behavior

Boostnote should validate hotkey before saving them.

Steps to reproduce

  1. Open hotkey setting
  2. Change a editor hotkey to Ctrl + Shift + V + B
  3. Save the hotkey
  4. Profit Crash

Environment

  • Version : 0.14 but probably all version of Boostnote is affected
  • OS Version and name : Linux, Windows, Mac
@ZeroX-DG ZeroX-DG added the bug 🐛 Issue concerns a bug. label Feb 27, 2020
@Flexo013 Flexo013 added the level 2 ❗ A bug that causes major damage: App is barely usable, since major features are not working. label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. level 2 ❗ A bug that causes major damage: App is barely usable, since major features are not working.
Projects
None yet
Development

No branches or pull requests

2 participants