Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add RTL support #846

Open
mbande opened this issue Sep 4, 2017 · 17 comments
Open

Please add RTL support #846

mbande opened this issue Sep 4, 2017 · 17 comments
Labels
feature request 🌟 Issue is a new feature request. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!

Comments

@mbande
Copy link

mbande commented Sep 4, 2017

Please paste some screenshots with the developer tool open if you report a bug.

@kazup01 kazup01 added feature request 🌟 Issue is a new feature request. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Sep 7, 2017
@asmsuechan
Copy link
Contributor

memo: rtlMoveVisually: boolean https://codemirror.net/doc/manual.html

@azarezade
Copy link

Lots of people use RLT language, please add it.
screen shot 1396-09-13 at 17 07 05
screen shot 1396-09-13 at 17 07 11

@nlopin
Copy link
Contributor

nlopin commented Mar 11, 2018

Guys, do you have any ideas how we can understand a note is written in RTL language?

@streamich
Copy link

Maybe we should not detect if language per note, but per user. If user's browser settings suggest he is using RTL language then the whole app should rearrange itself.

var language = window.navigator.userLanguage || window.navigator.language;

@streamich
Copy link

Also found this on Stackoverflow:

function isRTL(s){           
    var ltrChars    = 'A-Za-z\u00C0-\u00D6\u00D8-\u00F6\u00F8-\u02B8\u0300-\u0590\u0800-\u1FFF'+'\u2C00-\uFB1C\uFDFE-\uFE6F\uFEFD-\uFFFF',
        rtlChars    = '\u0591-\u07FF\uFB1D-\uFDFD\uFE70-\uFEFC',
        rtlDirCheck = new RegExp('^[^'+ltrChars+']*['+rtlChars+']');

    return rtlDirCheck.test(s);
};

@twastica
Copy link

twastica commented Aug 1, 2018

@dariubs
Perhaps this person's cooperation can be helpful in this project
the following project belongs to him:
https://github.com/dariubs/rtlmd

@IssueHuntBot
Copy link

@kazup01 cancelled funding, $20, of this issue. Visit this issue on Issuehunt

@kazup01 kazup01 added the bounty label Nov 7, 2018
@tuxitop
Copy link

tuxitop commented Mar 18, 2019

One solution can be adding a toggle-rtl option some place to change the preview mode to rtl and apply the appropriate styles to the preview pane. the settings could be consistent for each note (although not necessary).

@heydar110-hamid
Copy link

please add rtl language like persian to boostnote

@Flexo013 Flexo013 added funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. and removed 💵 Funded on IssueHunt labels Jul 25, 2019
@binyamin
Copy link

binyamin commented Sep 27, 2019

Would a rtl/ltr toggle suffice? @kazup01

@Flexo013
Copy link
Contributor

Flexo013 commented Oct 1, 2019

@b3u That should be enough for a first version with RTL support. If we want a better way of detecting it in the future then we can add that at a later point.

Thanks for wanting to implement this feature!

@tuxitop
Copy link

tuxitop commented Oct 3, 2019

There is also a direction library which checks a string and returns its direction based on the first (not neutral) character in the string. deciding the direction of each paragraph could be easier using this library, if dynamic changing of the direction is preferred.

@ibraude
Copy link
Contributor

ibraude commented Oct 17, 2019

Hey,

See #3282
I think that this satisfies the need for RTL support.

any ideas on improvements?

@tuxitop
Copy link

tuxitop commented Oct 17, 2019

@ibraude could it be possible to add a direction: ltr and text-align: left property for the code tag that would always be LTR?

@ibraude
Copy link
Contributor

ibraude commented Oct 17, 2019

@tuxitop Yeah, good catch. I added that and also an option to set up a hotkey for direction toggle

@aakbar5
Copy link

aakbar5 commented Jun 8, 2021

Do we have any fix or work around for this issue?

@arcturus140
Copy link
Contributor

afaik, yes. See #3282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!
Projects
None yet
Development

No branches or pull requests