Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size changes #927

Closed
asmsuechan opened this issue Oct 1, 2017 · 4 comments
Closed

Font size changes #927

asmsuechan opened this issue Oct 1, 2017 · 4 comments
Labels
bug 🐛 Issue concerns a bug. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!

Comments

@asmsuechan
Copy link
Contributor

asmsuechan commented Oct 1, 2017

I set the font size 90%, but it turns to 100% when I change the folder.

7628c8fbc44a4fa2400d77ceab28c9ff

env

macOS Sierra 10.12.6
development (on master branch 95d74d1)

@asmsuechan
Copy link
Contributor Author

It also happens on ubuntu

@kazup01 kazup01 added the bug 🐛 Issue concerns a bug. label Oct 4, 2017
@DennyScott
Copy link

Hey there, I'd like to try and take this bug on. I'll take a stab at it 👍

@DennyScott
Copy link

From what I can see, electron will reset their zoomLevel when there's a change to location. It's a bug that was resolved with this PR: electron/electron#8537, which allows session based persistence to zoom level, including closing the app.

This was released in Electron 1.6+. I fiddled with resetting the zoom level on a route load, but it would still cause the page to occasionally blink between sizes. Going to see what else I can do, but thoughts so far?

@kazup01 kazup01 added help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! and removed Hacktoberfest labels Nov 3, 2017
@Flexo013
Copy link
Contributor

This bug is no longer present in 0.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!
Projects
None yet
Development

No branches or pull requests

4 participants