Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grunt pre-build error #1104

Merged
merged 1 commit into from Nov 11, 2017
Merged

Conversation

yosmoc
Copy link
Member

@yosmoc yosmoc commented Nov 10, 2017

Before

./node_modules/grunt/bin/grunt pre-build
secret/auth_code.json is not found. CodeSigning is not available.
Running "pre-build" task

Running "compile" task
node_modules/.bin/webpack --config webpack-production.config.js
Hash: ccaf27ad4bf2df5d3c4b
Version: webpack 1.15.0
Time: 24077ms
    + 969 hidden modules

ERROR in main.js from UglifyJs
SyntaxError: Unexpected token punc «,», expected punc «:» [./~/markdown-it-plantuml/lib/deflate.js:6,0]

ERROR in finder.js from UglifyJs
SyntaxError: Unexpected token punc «,», expected punc «:» [./~/markdown-it-plantuml/lib/deflate.js:6,0]


Running "pack:osx" (pack) task
/Users/yoshi/src/github.com/yosmoc/Boostnote/dist
Packaging app for platform darwin x64 using electron v1.6.15

Done.

After

./node_modules/grunt/bin/grunt pre-build
secret/auth_code.json is not found. CodeSigning is not available.
Running "pre-build" task

Running "compile" task
node_modules/.bin/webpack --config webpack-production.config.js
Hash: 96f1d33ce56d038a4b30
Version: webpack 1.15.0
Time: 35587ms
    Asset     Size  Chunks             Chunk Names
  main.js   2.2 MB       0  [emitted]  main
finder.js  1.72 MB       1  [emitted]  finder
    + 968 hidden modules


Running "pack:osx" (pack) task
/Users/yoshi/src/github.com/yosmoc/Boostnote/dist
Packaging app for platform darwin x64 using electron v1.6.15

Done.

@kazup01 kazup01 self-requested a review November 11, 2017 01:43
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit e093c7f into BoostIO:master Nov 11, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 11, 2017

Merged. Thank you for your contribution!

@yosmoc yosmoc deleted the fix_grunt_pre-build_error branch November 12, 2017 00:19
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants