Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cm close brackets #1392

Merged
merged 2 commits into from
Jan 13, 2018
Merged

Cm close brackets #1392

merged 2 commits into from
Jan 13, 2018

Conversation

sosukesuzuki
Copy link
Member

I implemented one of the #1390 with a codemirror addon.
You enter a bracket, editor close a bracket automatically.
1 -13-2018 15-44-16

@jalalmostafa
Copy link

Thanks for implementing one of the features. It is awesome!

@Rokt33r Rokt33r deleted the cm-close-brackets branch January 14, 2018 03:38
@chang
Copy link
Contributor

chang commented Jan 16, 2018

@sosukesuzuki This may be nontrivial to implement since AFAIK there is no codemirror addon for it, but do you thinkautoclosing backticks and asterisks would be a worthwhile feature? My thought is that when editing markdown, we frequently enclose expressions in backticks for code blocks, and asterisks for *italic* **bold**.

@Rokt33r
Copy link
Member

Rokt33r commented Jan 17, 2018

@ericchang00 It should be nice to have. Could you create an issue for it?

@tewe
Copy link

tewe commented Feb 2, 2018

Thanks for adding this! How can I disable it?

@Rokt33r
Copy link
Member

Rokt33r commented Feb 2, 2018

@tewe It is not possible for now. How about you to try to implement it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants