Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monokai theme #1875

Merged
merged 3 commits into from
Apr 28, 2018
Merged

Monokai theme #1875

merged 3 commits into from
Apr 28, 2018

Conversation

yougotwill
Copy link
Member

This has been long overdue.

I'm planning on looking into custom themes otherwise I'll make a poll on slack for 3 more themes that we could add. 馃槃

monokai

Note
With the current way that themes are set up the codebase will become to bloated if we add a whole bunch of themes.
I'll try look into either making an adaptive theme based on the currently set syntax theme or allow people to select specific colors that the theme will use from the settings.

@kazup01 kazup01 added the awaiting review 鉂囷笍 Pull request is awaiting a review. label Apr 28, 2018
@kazup01 kazup01 self-requested a review April 28, 2018 01:48
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 9ff5cc5 into BoostIO:master Apr 28, 2018
@kazup01
Copy link
Member

kazup01 commented Apr 28, 2018

Merged. Thank you for your amazing contribution!
And your plan is sound great. I can not waiting for it 馃槃

@kazup01 kazup01 added next release (v0.11.5) and removed awaiting review 鉂囷笍 Pull request is awaiting a review. labels Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants