[Refactoring] - Removed unused packages #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
approved these changes
Jun 25, 2018
sosukesuzuki
added
next release (v0.11.8)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for Pull Request
While looking to fix some warnings I encountered when auditing the
package.jsonfile some packages popped up which are no longer used. Since the used version of superagent also contains a security vulnerability deleting them seems to be the most logical solution.Changes
Updated
package.jsonandyarn.lockto remove packages no longer being used.Tested
All code was searched looking for usage of the removed packages. No
require()or import statements were found for these packages.yarn testFinal comments
If you're actually still using some packages just say so and I'll modify the PR :) Had to recreate this PR after messing up my branch while trying to create a new PR