Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to abbreviations, definition lists and subscript/superscript text #2346

Merged
merged 11 commits into from
Nov 8, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Aug 27, 2018

This change adds support of:

  • abbreviations
  • subscript text
  • superscript text
  • definition lists (allow empty definition)

screenshot

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 27, 2018
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daiyam Could you resolve the conflicts?

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 15, 2018
@daiyam
Copy link
Contributor Author

daiyam commented Sep 15, 2018

@Rokt33r I've resolved the conflicts

@Rokt33r
Copy link
Member

Rokt33r commented Nov 8, 2018

@daiyam Could you fix the conflicts again? I'm sorry for being late.. 😢

@daiyam
Copy link
Contributor Author

daiyam commented Nov 8, 2018

@Rokt33r I've made the merge but I wasn't able to test. On the master, when I do yarn dev, I'm getting Electron: bad option: --hot out of the blue... or on an older version, it doesn't start...
I've broken something on my machine...

@Rokt33r
Copy link
Member

Rokt33r commented Nov 8, 2018

@daiyam Could you try to remove node_modules and execute yarn again? Btw, I'll test it by myself. :)

@daiyam
Copy link
Contributor Author

daiyam commented Nov 8, 2018

@Rokt33r I did tried, even removing yarn and electron caches. But then, I remembered, I've install some Python scripts. Not sure, what was the problem, but it was fixed after a reboot... 😔

I've made a small change in the styl file.

@Rokt33r
Copy link
Member

Rokt33r commented Nov 8, 2018

Okay! And I've tested this now. It looks Awesome! 💯

@Rokt33r Rokt33r merged commit 157eb5f into BoostIO:master Nov 8, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Nov 8, 2018
@daiyam daiyam deleted the text-deflist branch November 8, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants