Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message grammar #2404

Merged
merged 1 commit into from Sep 30, 2018
Merged

improve error message grammar #2404

merged 1 commit into from Sep 30, 2018

Conversation

jacobherrington
Copy link
Contributor

I noticed that a past tense error message would fit better in most cases.

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Sep 18, 2018
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added next release (v0.11.10) and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 26, 2018
@Rokt33r Rokt33r merged commit 7420363 into BoostIO:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants