Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug caused by poor regex #2448

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Fix bug caused by poor regex #2448

merged 2 commits into from
Nov 8, 2018

Conversation

jacobherrington
Copy link
Contributor

I created this bug in #2435. This should fix it.

screen shot 2018-09-30 at 6 18 12 pm 1

jacobherrington added 2 commits September 30, 2018 18:26
This shouldn't have been committed it was for testing. This commit
resets it to the original hotkey.
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 5, 2018
@ZeroX-DG ZeroX-DG requested a review from Rokt33r October 7, 2018 02:42
@jacobherrington
Copy link
Contributor Author

@Rokt33r this should get merged in before the next release, there is a bug that will happen to all hotkeys in the next release.

@Rokt33r Rokt33r added feature request 🌟 Issue is a new feature request. next release (v0.11.12) and removed awaiting review ❇️ Pull request is awaiting a review. feature request 🌟 Issue is a new feature request. labels Nov 8, 2018
@Rokt33r Rokt33r merged commit 69691bd into BoostIO:master Nov 8, 2018
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants