Add delete hotkey #2452
Merged
Add delete hotkey #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 30, 2018 20:17
Setting the default hotkeys to be more consistent on OS X (using the Alt notation as opposed to the Option notation).
ZeroX-DG
requested changes
Oct 13, 2018
browser/main/lib/ConfigManager.js
Outdated
| @@ -24,7 +24,8 @@ export const DEFAULT_CONFIG = { | |||
| amaEnabled: true, | |||
| hotkey: { | |||
| toggleMain: OSX ? 'Command + Alt + L' : 'Super + Alt + E', | |||
| toggleMode: OSX ? 'Command + Option + M' : 'Ctrl + M' | |||
| toggleMode: OSX ? 'Command + Alt + M' : 'Ctrl + M', | |||
| deleteNote: OSX ? 'Command + Alt + Backspace' : 'Ctrl + Alt + Backspace' | |||
There was a problem hiding this comment.
This hotkey is pure evil on Linux. It close all applications and go back to the login screen. Can you change it to Ctrl + Shift + Backspace
There was a problem hiding this comment.
Hahahaha yes
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.11)
awaiting changes 🖊️
Rokt33r
requested changes
Oct 23, 2018
|
@Rokt33r Fixed, pretty sure that's right :) |
ZeroX-DG
added
approved 👍
ZeroX-DG
approved these changes
Oct 27, 2018
Rokt33r
added
next release (v0.11.12)
and removed
approved 👍
yougotwill
added a commit
to yougotwill/Boostnote
that referenced
this pull request
Dec 2, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love to get some testing on this one 👍
Solves #2446