Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scrolling in note list #2455

Merged
merged 3 commits into from Dec 24, 2018
Merged

fix scrolling in note list #2455

merged 3 commits into from Dec 24, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Oct 1, 2018

This change fixes an annoying bug in the note list.

How to reproduce the bug:

  • when you have a long note list
  • if one of the top note is selected
  • then if you scroll and select one of the last note
  • the note is displayed
  • but the note list scrolls back (automatically) to the previous selected note

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 5, 2018
ZeroX-DG
ZeroX-DG approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 6, 2018
@Rokt33r Rokt33r added next release (v0.11.13) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Dec 24, 2018
@Rokt33r Rokt33r merged commit 7a3cab8 into BoostIO:master Dec 24, 2018
@daiyam daiyam deleted the fix-notelist branch December 24, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daiyam @ZeroX-DG @Rokt33r @kazup01