disable hyperlink for attachments #2474
Conversation
| @@ -52,7 +52,8 @@ | |||
|
|
|||
| if (className.indexOf('cm-url') !== -1) { | |||
| const match = /^\((.*)\)|\[(.*)\]|(.*)$/.exec(el.textContent) | |||
| return match[1] || match[2] || match[3] | |||
| const url = match[1] || match[2] || match[3] | |||
| return /^:storage\//.test(url) ? null : url | |||
There was a problem hiding this comment.
do you mind to use attachmentManagement.STORAGE_FOLDER_PLACEHOLDER instead of hard-coding :storage here?
There was a problem hiding this comment.
@ehhc it's not possible
require('../browser/main/lib/dataApi/attachmentManagement') throws the error Cannot find module 'browser/lib/findStorage'
hyperlink.js is loaded by Chromium
attachmentManagement.js is written to be loaded by node
There was a problem hiding this comment.
if it is really not possible (i am not a nodejs/electron pro, so i'm not sure about that) could you at least add an comment pointing to that file? That would help a lot in case somebody will refactor it again (e.g. in a few years..)
There was a problem hiding this comment.
@ehhc sure, I can do that
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.11)
and removed
approved 👍
This change disables the following popover on attached images:
