Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed storageList typo (storgaeList). #2547

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

mattkoskela
Copy link
Contributor

There was a typo with both the prop name (in the propTypes check) and the styleName for storageList-empty. This prevented the "No storage mount." div from ever being displayed (see the before and after screenshots attached).

Before:
before

After:
after

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 28, 2018
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 6, 2018
@Rokt33r Rokt33r merged commit dbd2c70 into BoostIO:master Nov 6, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Nov 6, 2018
@mattkoskela mattkoskela deleted the fix-storagelist-typo branch November 6, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants