Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode debug support #2571

Merged
merged 4 commits into from
Nov 12, 2018
Merged

Conversation

enyaxu
Copy link
Contributor

@enyaxu enyaxu commented Nov 4, 2018

  1. First run watch task. Terminal->Run Build Task… chose Build Boostnote task. Or you can run yarn run watch command in terminal.
  2. Now you can debug use F5

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 6, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 6, 2018

I don't know why but webpack-dev-server return 404 for the bundle file main.js. I'm on Linux. Can you check again?

@enyaxu
Copy link
Contributor Author

enyaxu commented Nov 8, 2018

@ZeroX-DG I change devServer to detail mode. Can you check again?

@ZeroX-DG
Copy link
Member

The webpack problem is somehow gone, but vscode now said that my breakpoint is Unverified breakpoint.

@enyaxu
Copy link
Contributor Author

enyaxu commented Nov 10, 2018

@ZeroX-DG When after start Build Boostnote task, You need to run debug config that named BoostNote All. And then you have two debug process running Boostnote main and Boostnote renderer. Now you need to switch process in vscode to debug your code. Like if you want to debug the code running in Boostnote renderer, you need to switch process to this.

This is because every Electron app have two process, Main process and Render process.

@ZeroX-DG
Copy link
Member

OK @enyaxu, it works now. I'm not familiar with vscode debug system so thank you for explaining. By the way, can you add the debug instruction to our docs? it's located here: https://github.com/BoostIO/Boostnote/blob/master/docs/debug.md

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 11, 2018
@enyaxu
Copy link
Contributor Author

enyaxu commented Nov 11, 2018

@ZeroX-DG Ok, I added the debug instruction to debug.md doc. Please review.

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your docs. Thank you very much

docs/debug.md Outdated Show resolved Hide resolved
docs/debug.md Outdated Show resolved Hide resolved
docs/debug.md Outdated Show resolved Hide resolved
docs/debug.md Outdated Show resolved Hide resolved
docs/debug.md Outdated Show resolved Hide resolved
docs/debug.md Outdated Show resolved Hide resolved
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! wrong action.

@enyaxu
Copy link
Contributor Author

enyaxu commented Nov 11, 2018

@ZeroX-DG Accept your suggestions, Thank you for you suggestions. 👍

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Nov 11, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Nov 12, 2018
@Rokt33r Rokt33r merged commit 235e88f into BoostIO:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants