Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom Controls #2601

Merged
merged 2 commits into from
Nov 25, 2018
Merged

Zoom Controls #2601

merged 2 commits into from
Nov 25, 2018

Conversation

yougotwill
Copy link
Member

@yougotwill yougotwill commented Nov 11, 2018

Description

Zoom Controls

  • Updated the zoom logic for the zoom in/out menu items so that if you zoom it reflects in the status bar and the config.
  • Also added an actual size / zoom reset menu item for convenience.

The shortcuts follow the standard controls I have seen in popular apps like google chrome or spotify.

You may notice that I have bound the zoom in to CommandOrControl+= instead of the standard CommandOrControl+Plus, this is due to an electron bug. I have posted a comment here. Feel free to check it out electron/electron#6731. The accelerator does the same thing so it has no effect on user experience.

I've tested everything on macOS and it seems to be fine πŸ‘
I need others to test on windows and linux please πŸ™

zoom controls

Issue fixed

#2554
#2089

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • πŸ”˜ Improvement (Change that improves the code. Maybe performance or development improvement)
  • πŸ”˜ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • πŸ”˜ All existing tests have been passed
  • πŸ”˜ I have attached a screenshot/video to visualize my change if possible

…zoom it reflects in the status bar and the config. Also added an actual size / zoom reset menu item for convenience.
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰

@ZeroX-DG ZeroX-DG added approved πŸ‘ Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 14, 2018
@ZeroX-DG
Copy link
Member

Confirm that it works fine on Linux.

@yougotwill
Copy link
Member Author

Awesome news πŸ‘ πŸ‘

@Rokt33r Rokt33r added next release (v0.11.12) and removed approved πŸ‘ Pull request has been approved by sufficient reviewers. labels Nov 25, 2018
@Rokt33r Rokt33r merged commit c7bae93 into BoostIO:master Nov 25, 2018
@yougotwill yougotwill deleted the zoom_controls branch November 25, 2018 10:02
@ZeroX-DG ZeroX-DG mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants