Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu items overhaul #2666

Merged
merged 4 commits into from
Dec 7, 2018
Merged

Menu items overhaul #2666

merged 4 commits into from
Dec 7, 2018

Conversation

yougotwill
Copy link
Member

@yougotwill yougotwill commented Dec 2, 2018

Description

This pr initially started as adding Clone Note to the menu bar and having a keyboard shortcut for it. However once I got started I thought that the menu items needed some restructuring and some of the keyboard shortcuts needed to be more platform friendly (i.e. using Command on macOS vs Control on Windows\Linux). Some of the keyboard shortcut changes are listed below.

Changed shortcuts

Focus Note: On macOS its now Command+E otherwise it remains Ctrl+E
Clone Note: On macOS its Command+D otherwise it is Ctrl+D

I made an attempt on bringing back the Delete key for non macOS machines but you can't have multiple accelerators on the same menuItem and I was too lazy to code it elsewhere πŸ€·β€β™‚οΈ I have also removed the Ctrl+D shortcut for deleting a note since the global shortcut is different as of this pr #2452 and I needed it for Clone Note πŸ˜„

I also noticed from this issue #2245 that the keyboard shortcuts wiki is seriously outdated. I can't update the wiki sadly but I hope that someone with power can do so after this PR is merged in to prevent any future confusion :)

What the menu items will now look like

file menu item

view menu item

Clone Note proof

clonenote

NOTE: I have not tested on either Linux or Windows can someone please test before merging. πŸ™

Issue fixed

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • πŸ”˜ Breaking change (Change that can cause existing functionality to change)
  • βšͺ Improvement (Change that improves the code. Maybe performance or development improvement)
  • πŸ”˜ Feature (Change that adds new functionality)
  • πŸ”˜ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • πŸ”˜ I have written test for my code and it has been tested
  • πŸ”˜ All existing tests have been passed
  • πŸ”˜ I have attached a screenshot/video to visualize my change if possible

… the super+shift+backspace shortcut which can be changed in the hotkey settings
…item and shortcut, updated focus note shortcut to be mac friendly, made delete note shortcut use either command+backspace or ctrl+backspace and the delete key on windows and linux machines
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 4, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Dec 6, 2018

LGTM but we gonna need someone with more high power to review this issue πŸ˜„ @Rokt33r

@ZeroX-DG ZeroX-DG requested a review from Rokt33r December 6, 2018 13:36
@ZeroX-DG ZeroX-DG added awaiting changes πŸ–ŠοΈ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 6, 2018
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rokt33r Rokt33r added next release (v0.11.12) and removed awaiting changes πŸ–ŠοΈ Pull request has been reviewed, but contributor needs to make changes. labels Dec 7, 2018
@Rokt33r Rokt33r merged commit 56851eb into BoostIO:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants