Dragged note highlighting #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroX-DG
added
bug 🐛
ZeroX-DG
requested changes
Dec 6, 2018
| handleDrop={(e) => this.handleDrop(e, storage, folder, dispatch, location)} | ||
| handleDragEnter={this.handleDragEnter} | ||
| handleDragLeave={this.handleDragLeave} | ||
| handleDrop={(e) => { |
There was a problem hiding this comment.
Can you move e.prevenDefault() to the this.handleDrop?
| e.preventDefault() | ||
| this.handleDrop(e, storage, folder, dispatch, location) | ||
| }} | ||
| handleDragEnter={(e) => { |
There was a problem hiding this comment.
Can you move e.prevenDefault() to the this.handleDrop?
browser/main/SideNav/StorageItem.js
Outdated
| this.handleDragEnter(e, folder.key) | ||
| }} | ||
| handleDragLeave={(e) => { | ||
| e.preventDefault() |
There was a problem hiding this comment.
Can you move e.prevenDefault() to the this.handleDrop?
ZeroX-DG
added
awaiting changes 🖊️
|
Thanks for implementing this. Never had time to do it myself but it is really needed (imho). Thanks :) |
|
Already changed the e.preventDefault() to the respective handlers. @ehhc Your welcome, I'm glad to be part of the project. |
ZeroX-DG
approved these changes
Dec 8, 2018
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.12)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the highlighting to more noticeable when a note is dragged over a folder.
Issue fixed
#1885
Type of changes
Checklist: