Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll Bars can now be hidden #2713

Merged
merged 8 commits into from
Feb 24, 2020
Merged

Conversation

gregueiras
Copy link
Contributor

Description

Users can now hide the scroll bars in the editor and in the markdown preview
ezgif com-optimize

Issue fixed

Issue #2174 make scroll bars visibility optional?

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 17, 2018
@ZeroX-DG
Copy link
Member

Can you fix the conflict? I think you don't need to restart the app to see the effect. To disable editor scroll bar you can apply the style to the editor component. And for the preview, we can apply the style and call the rewrite function to cause the preview to re-write. I haven't tested it yet but what do you think?

@gregueiras
Copy link
Contributor Author

Ok, I will look into that

@suefeng
Copy link

suefeng commented Nov 21, 2019

Is this feature no longer available? I wasn't able to find it in v0.13.0 (0.13.0).

@Flexo013
Copy link
Contributor

@suefeng This feature was never merged into the main project.

@gregueiras Could you fix the conflicts then we can merge this.

@gregueiras
Copy link
Contributor Author

Hi @Flexo013, I think I've fixed all conflicts 😃

I had another PR, that never got merged, if you could look into it it would be awesome, it allowed users to set a simple theme scheduler

@ZeroX-DG
Copy link
Member

@gregueiras sorry for the wait, can you resolve the conflict again please?

browser/main/lib/ConfigManager.js Outdated Show resolved Hide resolved
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 21, 2020
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Feb 21, 2020
@gregueiras
Copy link
Contributor Author

@ZeroX-DG, if you could take a look at #2658, it would be great!

@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 24, 2020
@Rokt33r Rokt33r merged commit fd54a7b into BoostIO:master Feb 24, 2020
@Flexo013
Copy link
Contributor

Might be related to #3486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved 👍 Pull request has been approved by sufficient reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants