Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to Electron 4 #2971

Closed
wants to merge 1 commit into from
Closed

Conversation

clone1612
Copy link
Contributor

Description

On Arch Linux the Electron package has already been upgraded to v4.x with which this package is not yet compatible. This is due to one particular breaking change which has been fixed with this PR.

Issue fixed

Electron 4 compatibility & upgrade. All tests pass without any issues and my manual tests have shown no broken functionality.

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • πŸ”˜ Improvement (Change that improves the code. Maybe performance or development improvement)
  • βšͺ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • πŸ”˜ All existing tests have been passed
  • βšͺ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Apr 14, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r April 14, 2019 21:46
@Rokt33r
Copy link
Member

Rokt33r commented May 9, 2019

I'm going to try this after I release v0.11.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review ❇️ Pull request is awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants