Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom CSS Disappears After Saving #3065

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Conversation

KazumiHARADA
Copy link
Contributor

Description

  • Removed the default value of the customCSS on the ReactCodeMirror TAG in order to enable stored the CustomCSS value.
  • Moved the default value to the ConfigManger.js.

Issue fixed

#3041

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • βšͺ Improvement (Change that improves the code. Maybe performance or development improvement)
  • βšͺ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • πŸ”˜ All existing tests have been passed
  • πŸ”˜ I have attached a screenshot/video to visualize my change if possible

Screenshot

customcss

Tested

MacOS Mojave (10.14.5)

@KazumiHARADA KazumiHARADA changed the title [update] move default value of the customCSS field to ConfigManager Fix Custom CSS Disappears After Saving Jun 8, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jun 9, 2019

The /* Drop Your Custom CSS Code Here */ was there to fix this issue: #2789

With your current code, if the user clears the custom CSS editor, the old issue will appear again. Can you make the /* Drop Your Custom CSS Code Here */ into a placeholder or something?

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 9, 2019
@KazumiHARADA
Copy link
Contributor Author

I've modified inserting the default value to the custom CSS field when the field was saved empty.
Please check my code again.

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰

@ZeroX-DG ZeroX-DG added approved πŸ‘ Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 15, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 8, 2019
@Rokt33r Rokt33r merged commit b8de51b into BoostIO:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved πŸ‘ Pull request has been approved by sufficient reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants