Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom CSS Disappears After Saving #3065

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@KazumiHARADA
Copy link

commented Jun 8, 2019

Description

  • Removed the default value of the customCSS on the ReactCodeMirror TAG in order to enable stored the CustomCSS value.
  • Moved the default value to the ConfigManger.js.

Issue fixed

#3041

Type of changes

  • 馃敇 Bug fix (Change that fixed an issue)
  • 鈿笍 Breaking change (Change that can cause existing functionality to change)
  • 鈿笍 Improvement (Change that improves the code. Maybe performance or development improvement)
  • 鈿笍 Feature (Change that adds new functionality)
  • 鈿笍 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 馃敇 My code follows the project code style
  • 鈿笍 I have written test for my code and it has been tested
  • 馃敇 All existing tests have been passed
  • 馃敇 I have attached a screenshot/video to visualize my change if possible

Screenshot

customcss

Tested

MacOS Mojave (10.14.5)

@KazumiHARADA KazumiHARADA changed the title [update] move default value of the customCSS field to ConfigManager Fix Custom CSS Disappears After Saving Jun 8, 2019

@ZeroX-DG

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

The /* Drop Your Custom CSS Code Here */ was there to fix this issue: #2789

With your current code, if the user clears the custom CSS editor, the old issue will appear again. Can you make the /* Drop Your Custom CSS Code Here */ into a placeholder or something?

@KazumiHARADA

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

I've modified inserting the default value to the custom CSS field when the field was saved empty.
Please check my code again.

@ZeroX-DG
Copy link
Member

left a comment

LGTM 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.