Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tray icon to show up to 10 recently updated notes #3104

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

AWolf81
Copy link
Contributor

@AWolf81 AWolf81 commented Jul 3, 2019

Description

It's based on PR #1536. Once this is ready we can close the other PR.

I've changed menu creation so it is showing the 10 recently updated notes across all storage location and added a filter for an empty title as I think we don't want to show blank lines in the tray or should we handle this differently?

Notes from my review of other PR:

  • After starting it seems like the tray menu is not loading the most recently edited notes. I think after clicking on a storageLocation it will correctly show the menu. After first run in binary the recent notes menu in the tray is empty. After the first edit the menu gets populated. I'll check if that's happening after every start or just the first start. I've added a todo to the list below
  • The tray is showing the recently edited notes related to the currently selected storage location. Is this like we want it? IMO it would be better to have the recently edited notes across all storage locations - like it is with the note links below the search field. Added
  • I had sometimes multiple tray icon symbols - not sure if this is related to hot module reloading or if there is a real problem. Not happend again

Todos:

  • Initial loading of recent notes seems to be not working but it's just a click issue. Left mouse won't show recent notes but right mouse click works correctly. Ideally left & right should display the same menu (if possible) I think it's OK to have it only on right click. Not found a fix as Electron is problematic to handle the tray clicks properly - tried to add right-click handler but with-out success

  • Filter trashed notes from the tray menu as link click for deleted items wasn't working properly.

  • Linux Mint issues (skipped Mint testing as I have troubles with my VM ware image. Ubuntu is working)

    • Check tray icon display - not completely displayed in dev only (won't fix). Working in binary
    • Click on a recent note won't maximize/focus the app (app focus/maximize works on Windows)
    • Check app binary. Not starting the app - missing dependency.
  • OS tests

    • Windows 10

      • dev server OK tray icon showing & links are working
      • binary
    • Linux (I will check Ubuntu & Linux Mint)

      • Linux Mint (skipped testing)
        • dev server (smaller issues, see todo above - right & left click consistently displays the populated context menu)
        • binary
      • Linux Ubuntu 18.0.4 (64bit)
        • Dev server (tray icon in top right corner, opens same menu on left & right click, app maximizes on note selection)
        • binary
    • MacOs (I need support here as I don't have access to a Mac)

      • dev server
      • binary

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

Screenshots

Windows 10
grafik

Ubuntu 18.0.4
grafik

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jul 5, 2019
@Rokt33r Rokt33r self-assigned this Jul 27, 2019
@Rokt33r Rokt33r self-requested a review July 27, 2019 05:38
@Rokt33r Rokt33r removed their assignment Jul 27, 2019
@Rokt33r
Copy link
Member

Rokt33r commented Jul 27, 2019

I'll check macOS

@AWolf81
Copy link
Contributor Author

AWolf81 commented Feb 20, 2020

OK, I've updated this and tested it again.

The only thing I've noticed is that the link menu is just showing on right-click. Tested on Windows.
I'd like to have the same display for the left mouse click but I'm not sure how to fix this.

I have to check how it's working in Linux.

@Rokt33r
Copy link
Member

Rokt33r commented Feb 21, 2020

I'll also check this in this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review ❇️ Pull request is awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants