Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debounce deletion of un-referenced attachments --> don't fixes but mi… #3107

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Debounce deletion of un-referenced attachments --> don't fixes but mi… #3107

merged 2 commits into from
Jul 10, 2019

Conversation

ehhc
Copy link
Contributor

@ehhc ehhc commented Jul 5, 2019 •
edited

Debounce deletion of un-referenced attachments --> don't fixes but mitigates the problems of #3103

@ehhc ehhc mentioned this pull request Jul 5, 2019
Open
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jul 6, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jul 6, 2019

@Rokt33r What do you think about this solution? Is there a better way to deal with this?

Rokt33r
Rokt33r requested changes Jul 8, 2019
View reviewed changes
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :) I think it is kind of the best. @ZeroX-DG

But the console message looks broken. Could you fix it? @ehhc

browser/main/lib/dataApi/attachmentManagement.js Outdated Show resolved Hide resolved
@ehhc
Update attachmentManagement.js
1219d3f 
Deleting unneeded stupid log-message
@Rokt33r Rokt33r removed the awaiting review ❇️ Pull request is awaiting a review. label Jul 10, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 10, 2019
@Rokt33r Rokt33r merged commit cb7ac77 into BoostIO:master Jul 10, 2019
@ehhc ehhc deleted the debounce_removing_unreferrenced_attachments branch July 10, 2019 06:11
@Flexo013 Flexo013 mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Rokt33r requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehhc @ZeroX-DG @Rokt33r