Fix 3060 #3181
Merged
Fix 3060 #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now there are only two export types that are using a special output formatter, pdf and html. Both of these formatters currently populate the `/html/head/base` portion of the associated html document with the name of the target directory for the file that the user is exporting. In order for internal links within the exported document to work correctly, the value of base must also include the filename. This fix removes the call to `path.dirname`, which gets rid of the necessary filename.
ZeroX-DG
added
needs extra review 🔎
Rokt33r
removed
the
needs extra review 🔎
|
Could be related to the latest issue with TOC's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now there are only two export types that are using a special
output formatter, pdf and html. Both of these formatters currently populate the
/html/head/baseportion of the associated html document with the nameof the target directory for the file that the user is exporting.
In order for internal links within the exported document to work
correctly, the value of base must also include the filename. This fix
removes the call to
path.dirname, which gets rid of the necessaryfilename.
Issue fixed
#3060
Type of changes
Checklist: