Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3174: Enable dragging of notes #3195

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

AWolf81
Copy link
Contributor

@AWolf81 AWolf81 commented Aug 1, 2019

Description

user-drag: none style from MarkdownNoteDetail.styl was applied to every div in the app and disabled dragging of notes.

Changed styling to address only the buttons/icons to disable the dragging of them.

One point where I'm not sure - was dragging of notes to trash icon supported by a previous app version because that's not working but I'm not sure if that was available before.

Issue fixed

#3174

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • βšͺ Improvement (Change that improves the code. Maybe performance or development improvement)
  • βšͺ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • βšͺ All existing tests have been passed
  • πŸ”˜ I have attached a screenshot/video to visualize my change if possible

Screenshots

Note dragging
Screenrecording_Note_Dragging

Disabled dragging in NoteDetailInfo bar still working
Screenrecording_NoteDetailInfo_not_draggable

A bit difficult to show in a screenrecording but I clicked every icon in the upper right bar and tried to drag the icon. The circle on the cursor during dragging is from the screenrecorder indicating a mousedown.

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 2, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰ I didn't think of the drag n drop note feature is using the default dragging behavior. Thanks for fixing this πŸ‘

@ZeroX-DG ZeroX-DG added needs extra review πŸ”Ž Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 2, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r August 2, 2019 23:42
@Rokt33r Rokt33r removed the needs extra review πŸ”Ž Pull request requires review from an additional reviewer. label Aug 24, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 24, 2019
@Rokt33r Rokt33r merged commit 2f1dadf into BoostIO:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants