Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeEditor::setLineContent method to manipulate line contents #3197

Merged
merged 1 commit into from Aug 24, 2019

Conversation

hikerpig
Copy link
Contributor

@hikerpig hikerpig commented Aug 2, 2019

Description

Avoid changing all CodeMirror instance's contents.

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)

…related BoostIO#3163

Avoid changing all CodeMirror instance's contents
@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 2, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 6, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Aug 24, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 24, 2019
@Rokt33r Rokt33r merged commit 2352c78 into BoostIO:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on Check boxes and footnotes take you back to the very top of the note
4 participants