Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix throwing of exception on multiple instances #3243

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Fix throwing of exception on multiple instances #3243

merged 2 commits into from
Oct 10, 2019

Conversation

jhdcruz
Copy link
Contributor

@jhdcruz jhdcruz commented Sep 5, 2019

Description

Prevents throwing of exception when multiple instances of Boostnote are initiated.

Issue fixed

Fixes #3241

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@jhdcruz
Single Instance fix #3241
762f8b3 
Fixes single instance depreciation
@jhdcruz jhdcruz changed the title Single Instance fix #3241 Fix throwing of exception on multiple instances Sep 5, 2019
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Sep 5, 2019
ZeroX-DG
ZeroX-DG approved these changes Sep 8, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 8, 2019
@jhdcruz jhdcruz mentioned this pull request Sep 9, 2019
Closed
@malorie16 malorie16 mentioned this pull request Oct 3, 2019
Closed
@jhdcruz
Merge pull request #1 from BoostIO/master
6ba1d50 
merge `master` origin banch into PR
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Oct 10, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Oct 10, 2019
@Rokt33r Rokt33r merged commit 3c0f20f into BoostIO:master Oct 10, 2019
@ZeroX-DG ZeroX-DG mentioned this pull request Jan 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Exception was thrown when two boostnote is launched
3 participants
@jhdcruz @ZeroX-DG @Rokt33r