Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used the same hot-key pattern as the one already in use #3256

Closed
wants to merge 1 commit into from
Closed

Used the same hot-key pattern as the one already in use #3256

wants to merge 1 commit into from

Conversation

Olcod
Copy link
Contributor

@Olcod Olcod commented Sep 30, 2019

Description

Used the same hot-key pattern as everything else

Issue fixed

#3246

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

ZeroX-DG
ZeroX-DG approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added the approved 👍 Pull request has been approved by sufficient reviewers. label Oct 1, 2019
@Rokt33r
Copy link
Member

Rokt33r commented Oct 10, 2019

This conflicts #3257. How should we handle this pr?

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Oct 10, 2019
@Rokt33r
Copy link
Member

Rokt33r commented Oct 10, 2019

I misunderstood. No problem. But I committed it directly in here! Thanks for the contribution!
8736666

@Rokt33r Rokt33r closed this Oct 10, 2019
@Rokt33r Rokt33r removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Oct 10, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Olcod @Rokt33r @ZeroX-DG