Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-3160] Add ability to sort lines with hotkey combination #3257

Merged
merged 2 commits into from
Oct 10, 2019
Merged

[Issue-3160] Add ability to sort lines with hotkey combination #3257

merged 2 commits into from
Oct 10, 2019

Conversation

Olcod
Copy link
Contributor

@Olcod Olcod commented Oct 2, 2019 •
edited
Loading

Description

Just had a crack, not sure if this is production ready yet.
But, if anyone could take a look at it and let me know what do you think would be great.

Issue fixed

#3160

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

There is the markdown-toc-generator-test test failing, but I'm not sure why, I don't think I change any files relevant to it.

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 4, 2019
@Flexo013
Copy link
Contributor

Flexo013 commented Oct 8, 2019

If this is merged then this page will need updating: https://github.com/BoostIO/Boostnote/wiki/Keyboard-Shortcuts

ZeroX-DG
ZeroX-DG approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 9, 2019
@Rokt33r Rokt33r merged commit ef0af39 into BoostIO:master Oct 10, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Oct 10, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Oct 10, 2019
@Rokt33r Rokt33r mentioned this pull request Oct 10, 2019
Closed
@Flexo013
Copy link
Contributor

Flexo013 commented Oct 11, 2019 •
edited
Loading

Updated keyboard shortcuts

@Olcod Olcod deleted the iss-3160/add-ability-to-sort-lines branch October 29, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Olcod @Flexo013 @ZeroX-DG @Rokt33r