Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to "New note from URL" dialog #3313

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

AWolf81
Copy link
Contributor

@AWolf81 AWolf81 commented Oct 24, 2019

Description

Adds error handling for "New note from URL" dialog.

Issue fixed

Fixes #3308

  • Display error message on url not found
  • Keep "New note" functional

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • βšͺ Improvement (Change that improves the code. Maybe performance or development improvement)
  • βšͺ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • πŸ”˜ All existing tests have been passed
  • πŸ”˜ I have attached a screenshot/video to visualize my change if possible

Screenshots

URL not found
grafik

Wrong url format - missing .com
grafik

Comments

  • Is it OK to add the messages as a constant into the file? Or is there a constants file where we could add it?
  • Unexpected error message is just a fallback if the code is not matching and I think that's OK.
  • Are the error messages OK? I've added the check your internet connection because you're also getting ENOTFOUND with-out internet connection.

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 25, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰ You probably won't re-use these message in the future so I think putting them here is good enough:)

@ZeroX-DG ZeroX-DG added approved πŸ‘ Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 27, 2019
@Rokt33r Rokt33r added this to the v0.14.0 milestone Oct 28, 2019
@Rokt33r Rokt33r removed the approved πŸ‘ Pull request has been approved by sufficient reviewers. label Oct 28, 2019
@Rokt33r Rokt33r merged commit 1d84cac into BoostIO:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't make new notes after failed URL to note conversion
4 participants