Add error handling to "New note from URL" dialog #3313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds error handling for "New note from URL" dialog.
Issue fixed
Fixes #3308
Type of changes
Checklist:
Screenshots
URL not found
![grafik](https://user-images.githubusercontent.com/3046542/67517038-00332f00-f6a2-11e9-9ac1-792370936fc0.png)
Wrong url format - missing .com
![grafik](https://user-images.githubusercontent.com/3046542/67517120-28229280-f6a2-11e9-9d2b-31911ee6a37d.png)
Comments
Unexpected
error message is just a fallback if the code is not matching and I think that's OK.ENOTFOUND
with-out internet connection.