Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emoji render on notes list #3385

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Fix emoji render on notes list #3385

merged 1 commit into from
Dec 23, 2019

Conversation

abnersajr
Copy link
Contributor

Description

This PR adds a package to render emojis in the notes list.

Issue fixed

It fixes the issue #3338

image

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@abnersajr abnersajr closed this Dec 3, 2019
@abnersajr abnersajr reopened this Dec 3, 2019
@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Dec 3, 2019
ZeroX-DG
ZeroX-DG approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 8, 2019
@Rokt33r Rokt33r added this to the v0.14.0 milestone Dec 23, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Dec 23, 2019
@Rokt33r Rokt33r merged commit 3c12e0d into BoostIO:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abnersajr @ZeroX-DG @Flexo013 @Rokt33r