Fixed 'Image path of exported image is wrong' #3392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d expect the correct format
cyrus303
approved these changes
Dec 14, 2019
AlfredoGJ
changed the title
|
I think this one is a duplicate to this one: #2897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug #2785 Image path of exported image is wrong
When the function that replaces the image link in the note was looking to replace it, it did not worked. This was because the regex that is supposed to match the image link was incorrect.
The replace function was searching for something like:
when in the note the images links have the format:
The tests also were expecting something wrong, so they were changed.
Issue fixed
#2785 Image path of exported image is wrong
Type of changes
🔘 Bug fix (Change that fixed an issue)
⚪ Breaking change (Change that can cause existing functionality to change)
⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
⚪ Feature (Change that adds new functionality)
⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)
Checklist:
🔘 My code follows the project code style
🔘 I have written test for my code and it has been tested ()
🔘 All existing tests have been passed
⚪ I have attached a screenshot/video to visualize my change if possible