Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mermaid #3590

Merged
merged 2 commits into from
Jul 20, 2020
Merged

update mermaid #3590

merged 2 commits into from
Jul 20, 2020

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Jun 13, 2020 •
edited
Loading

Description

This change fixes the missing arrowheads in mermaid flowcharts. (mermaid-js/mermaid#1138)

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
  • ⚪ This PR will modify the UI or affects the UX
  • ⚪ This PR will add/update/delete a keybinding

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 14, 2020
ZeroX-DG
ZeroX-DG approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 14, 2020
@Rokt33r Rokt33r merged commit 071ce12 into BoostIO:master Jul 20, 2020
@Rokt33r Rokt33r added this to the v0.16.0 milestone Jul 20, 2020
@daiyam daiyam deleted the fix-mermaid-arrow branch July 20, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
approved 👍 Pull request has been approved by sufficient reviewers.
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daiyam @ZeroX-DG @Rokt33r