Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RcParser ignore errors at JSON.parse() #789

Merged
merged 1 commit into from Aug 10, 2017
Merged

Make RcParser ignore errors at JSON.parse() #789

merged 1 commit into from Aug 10, 2017

Conversation

asmsuechan
Copy link
Contributor

context

before

The settings turned DEFAULT if ~/.boostntoerc is invalid json.

after

The original settings in localStorage will be used even if ~/.boostnoterc is invalid json.

@asmsuechan asmsuechan merged commit 8f4566b into BoostIO:master Aug 10, 2017
@asmsuechan asmsuechan deleted the try-catch-in-rc-parser branch August 10, 2017 23:38
@kazup01 kazup01 mentioned this pull request Aug 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asmsuechan @kazup01 @BoostnoteBot