Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Ctrl + /" and "Shift + Ctrl + /" to insert today's date and time #2962

Merged
merged 1 commit into from Apr 12, 2019
Merged

Add "Ctrl + /" and "Shift + Ctrl + /" to insert today's date and time #2962

merged 1 commit into from Apr 12, 2019

Conversation

amedora
Copy link
Contributor

@amedora amedora commented Apr 3, 2019

Description

Added new shortcuts:

  • Ctrl+/ to inserts today's date
  • Shift+Ctrl+/ to inserts today's date & time

Issue fixed

insertdatenow

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
    • got error when "npm run test" on Windows environment.
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Apr 4, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 5, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r April 7, 2019 22:04
@Rokt33r Rokt33r merged commit aea9673 into BoostIO:master Apr 12, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Apr 12, 2019
@Rokt33r Rokt33r removed needs extra review 🔎 Pull request requires review from an additional reviewer. approved 👍 Pull request has been approved by sufficient reviewers. labels Apr 12, 2019
@amedora amedora deleted the issue-1765 branch May 31, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants