feat: Improve output when transfers are approved/cancelled and event data in sync #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDXTransferApproval Possible State
IDXTransferApproval outer joined with TransferApprovalHistory Matrix
|
Comment on lines
+1981
to
+2004
| ( | ||
| and_(IDXTransferApproval.escrow_finished == True, | ||
| IDXTransferApproval.transfer_approved == None, | ||
| TransferApprovalHistory.operation_type == None), | ||
| 1 | ||
| ), # EscrowFinish(escrow_finished) | ||
| ( | ||
| and_(IDXTransferApproval.transfer_approved == None, | ||
| TransferApprovalHistory.operation_type == TransferApprovalOperationType.APPROVE.value), | ||
| 2 | ||
| ), # Approve(operation completed, event synchronizing) | ||
| ( | ||
| IDXTransferApproval.transfer_approved == True, | ||
| 2 | ||
| ), # Approve(transferred) | ||
| ( | ||
| and_(IDXTransferApproval.cancelled == None, | ||
| TransferApprovalHistory.operation_type == TransferApprovalOperationType.CANCEL.value), | ||
| 3 | ||
| ), # Cancel(operation completed, event synchronizing) | ||
| ( | ||
| IDXTransferApproval.cancelled == True, | ||
| 3 | ||
| ), # Cancel(canceled) |
There was a problem hiding this comment.
From this perspective found no problems. LGTM.
(It is more intuitive to match "transferred" event first.)
batch/indexer_transfer_approval.py
Outdated
Comment on lines
32
to
33
| import config | ||
|
|
There was a problem hiding this comment.
This line should be written after root path import.
purplesmoke05
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #390
The following modifications have been made to resolve #390 issues.
Please provide feedback.
transfer_approval_history). The record is added only when the approval or cancellation is successful. Note that this TBL was converted from one that already existed and was not being used.