Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] App does not work when balance is too big #148

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

LaimeJesus
Copy link
Contributor

related #143

Description

This PR fixes the issue that was impeding to use the application to Martin, there was an issue with the amount of tokens that he had, it adds the following changes:

  • Fixes
    • issue when user has a big amount of crc tokens, the main issue was using parseInt instead of using them as BigNumbers
  • use new transformation from number to string in useMintGroupToken hook
  • Changes
    • formatToken does not return a number anymore, adds a fromBN method
    • conversion function from string to circles and tc amounts does not convert to numbers anymore

How to Test

To test this fixes we need to import the Martin safe address account into the your safe app:

  • Martin Address: 0x42cEDde51198D1773590311E2A340DC06B24cB37

After that, do the usual steps:

  • import the custom safe app
    as we aren't the owners of the safe, we will only be able to navigate the app
  • navigate some of the pages
  • go to mint tokens for a group

Example

  • initial page
    image

  • mint group shisus group page
    image

@vercel
Copy link

vercel bot commented Jul 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
circles-groups-safe-app ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 7:15PM (UTC)

@LaimeJesus LaimeJesus changed the title Bug/#143 app does not work when balance is too big [BUG] App does not work when balance is too big Jul 27, 2022
Copy link
Contributor

@marcelorubini marcelorubini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App is loading without any issue after importing Martin's safe! 🚀

Screenshot from 2022-07-28 14-28-48

Screenshot from 2022-07-28 14-25-07

@LaimeJesus LaimeJesus merged commit 5435279 into dev Jul 28, 2022
@LaimeJesus LaimeJesus deleted the bug/#143-app-does-not-work-when-balance-is-too-big branch July 28, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants