Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix the url links showed in the Toast when a Tx start #175

Merged
merged 4 commits into from
Aug 10, 2022

Conversation

LaimeJesus
Copy link
Contributor

related #164

Description

This PR fixes how the url are generated in the useTransaction and useSafeTransaction hooks:

Examples

Create Group

https://blockscout.com/xdai/mainnet/tx/0xa6cb6a89be41876ed2c1ec81ee5186ac4328c418dc66bf09d6b42552d126aa62

image
image

Mint Group Tokens
https://blockscout.com/xdai/mainnet/tx/0xc4bde5a05c834ccf4be59dc67133738fc909fd7e5257cab976711e3d8f2ce847
2022-08-05_18-06_1

image

…iting status

when tx start it only has the gnosis tx, so user only can see their transaction history

after confirming tx in wallet(mm) the tx has an available hash for the explorer
…e tx generated by the safe needs to wait an amount of time until it gets accepted

adds a awful waiting for safeTx function
@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
circles-groups-safe-app ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 9:09PM (UTC)

Copy link
Contributor

@tloffler tloffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Links are now working fine.

Copy link
Contributor

@marcelorubini marcelorubini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working properly! 🚀

@LaimeJesus LaimeJesus merged commit 0f60b0b into dev Aug 10, 2022
@LaimeJesus LaimeJesus deleted the fix/#164-url-links branch August 10, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants