Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using on property requires reload and loses animation #15

Closed
danie11am opened this issue Jan 12, 2016 · 6 comments
Closed

Using on property requires reload and loses animation #15

danie11am opened this issue Jan 12, 2016 · 6 comments

Comments

@danie11am
Copy link

If the on value is set without calling reload, the entire checkbox disappears. It is actually still tappable, and would re-appear when it is tapped to on.

Then I tried calling reload after changing on value. This time the checkbox won't disappear, but the on/off animation will be gone forever in this checkbox instance.

@Boris-Em
Copy link
Owner

Hi @danie11am,
Thank you for opening this issue!
What version of BEMCheckBox are you currently using?

This is potentially a duplicate of #6.

@danie11am
Copy link
Author

No problem! I'm using 2.1.0.

@Boris-Em
Copy link
Owner

Thanks @danie11am, but the latest version of BEMCheckBox is 1.2.0!
Would you mind checking with this version that the bug still occurs?
In the meantime I going to close this bug because I strongly suspect it to be fixed with 1.2.0.
Thank again!

@danie11am
Copy link
Author

Argh! I'm sorry - I was using 1.1.0. Sure I'll try 1.2.0.

@danie11am
Copy link
Author

Yep it works. No need to call reload(). And the "loses animation" bit was probably my mistake, where my "didTapOnCheckbox" would cause a state change, and the didSet of my state change set the checkbox.on, therefore losing the animation. Fixed that too. - Thanks again!

@Boris-Em
Copy link
Owner

@danie11am,
Great to hear, thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants