Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useBanner flag isn't being followed #22

Closed
Ron-Kuper-Bose opened this issue Aug 1, 2019 · 1 comment
Closed

useBanner flag isn't being followed #22

Ron-Kuper-Bose opened this issue Aug 1, 2019 · 1 comment

Comments

@Ron-Kuper-Bose
Copy link

It seems the useBanner parameter isn't being respected. We have some code that tries to use the logger with useBanner=false and we still get a banner.

I think line 52 in middleware.go is the culprit - you create a logging buffer WithBanner(true) unconditionally.
@Jim-Lambert-Bose Jim-Lambert-Bose mentioned this issue Aug 2, 2019
Merged
@Jim-Lambert-Bose
Copy link

fixed in: https://github.com/Bose/go-gin-logrus/releases/tag/v2.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jim-Lambert-Bose @Ron-Kuper-Bose