Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Redigo version #3

Closed
yfei1 opened this issue Jan 14, 2020 · 2 comments
Closed

Upgrade Redigo version #3

yfei1 opened this issue Jan 14, 2020 · 2 comments

Comments

@yfei1
Copy link

yfei1 commented Jan 14, 2020

Current go.mod file automatically pulled the redigo dependency v2.0.0, which is not the latest release - yes, their latest release is v1.7.1 but not v2.0.0. This would result in dependency incompatibilities for users who are using the v1.7 version since there are features only available in the 1.7 version. It would be great if minisentinel could support the edge features e.g. redisPool.DialContext.
@Jim-Lambert-Bose
Copy link
Contributor

redigo is a semvar mess at the moment: gomodule/redigo#366
and has been a mess since it made that v2 release on Mar 15, 2018.

Hum... I'll see what I can do today to make things better for minisentinel

@Jim-Lambert-Bose Jim-Lambert-Bose mentioned this issue Jan 15, 2020
Merged
@Jim-Lambert-Bose
Copy link
Contributor

fix has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yfei1 @Jim-Lambert-Bose