Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lexer): use SIMD to skip single line comment #17

Closed
wants to merge 2 commits into from
Closed

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Feb 13, 2023

Speeding up single line comment parsing should save a few millisecond.

image

On the other hand, skipping multi-line comments in chunks will give us a huge improvement.

@Boshen Boshen marked this pull request as draft February 13, 2023 00:58
@github-actions
Copy link

github-actions bot commented Feb 13, 2023

Parser Benchmark Results

group                    main                                   pr
-----                    ----                                   --
parser/babylon.max.js    1.00    126.3±1.23ms    81.7 MB/sec    1.00    126.7±0.75ms    81.5 MB/sec
parser/d3.js             1.00     16.2±0.05ms    33.8 MB/sec    1.01     16.3±0.10ms    33.5 MB/sec
parser/lodash.js         1.00      4.6±0.09ms   112.1 MB/sec    1.00      4.6±0.08ms   111.9 MB/sec
parser/pdf.js            1.00      9.2±0.07ms    43.7 MB/sec    1.01      9.3±0.09ms    43.1 MB/sec
parser/typescript.js     1.00    128.7±0.70ms    74.7 MB/sec    1.00    128.4±0.97ms    74.9 MB/sec

@Boshen Boshen force-pushed the simd-comment branch 2 times, most recently from cfbd79e to 949ebea Compare February 13, 2023 02:03
@Boshen Boshen added this to the AST / Lexer / Parser milestone Feb 21, 2023
@Boshen
Copy link
Member Author

Boshen commented Feb 21, 2023

This is not adding much performance. Closing.

@Boshen Boshen closed this Feb 21, 2023
@Boshen Boshen deleted the simd-comment branch February 23, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant