Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland support? #2233

Closed
TheRegularDX opened this issue Jan 10, 2023 · 7 comments
Closed

Wayland support? #2233

TheRegularDX opened this issue Jan 10, 2023 · 7 comments
Labels
suggestion New feature or request

Comments

@TheRegularDX
Copy link

Cool ideas?

Wayland support?

@TheRegularDX TheRegularDX added the suggestion New feature or request label Jan 10, 2023
@github-actions
Copy link
Contributor

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

@Botspot
Copy link
Owner

Botspot commented Jan 10, 2023

Please be specific. Is Pi-Apps failing to launch for you on Wayland?

@TheRegularDX
Copy link
Author

Please be specific. Is Pi-Apps failing to launch for you on Wayland?

Yes, currently the only way to use it on wayland is with Xwayland, it runs perfectly fine but official support would be pretty nice

@Botspot
Copy link
Owner

Botspot commented Jan 10, 2023

Wayland does not support window positioning, but Xwayland does. The current Pi-Apps interface uses a dual-pane interface, which only works if both windows can choose their exact position on the screen.

But maybe we've missed something! You can try using Pi-Apps on Wayland by commenting out one line of code.
Go to the ~/pi-apps/api script, and scroll all the way to the bottom.
The final few lines of the file will include:

#Make dual-pane yad windows work correctly on wayland
export GDK_BACKEND=x11

Comment out that one line mentioning "export" and then run Pi-Apps again.

@TheRegularDX
Copy link
Author

Wayland does not support window positioning, but Xwayland does. The current Pi-Apps interface uses a dual-pane interface, which only works if both windows can choose their exact position on the screen.

But maybe we've missed something! You can try using Pi-Apps on Wayland by commenting out one line of code.
Go to the ~/pi-apps/api script, and scroll all the way to the bottom.
The final few lines of the file will include:

#Make dual-pane yad windows work correctly on wayland
export GDK_BACKEND=x11

Comment out that one line mentioning "export" and then run Pi-Apps again.

That worked... i think? Thank you for your help

@Botspot
Copy link
Owner

Botspot commented Jan 11, 2023

That worked... i think? Thank you for your help

To clarify, was something not working before you made this change? Did the dual-pane layout continue working after this change?

@theofficialgman
Copy link
Collaborator

theofficialgman commented Jan 11, 2023

native wayland simply cannot work using yad.
there is no support for defining window placement in the wayland protocol. it is never coming, they do not want it, its against wayland philosophy (see: https://gitlab.freedesktop.org/wayland/wayland/-/issues/183).

pi-apps relies on this feature to properly place top level windows for our dual pane feature, as well as update notifications, so xwayland (that like X11 does have this functionality) is forced through the use of that variable

@Botspot Botspot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants