Skip to content
This repository has been archived by the owner on Jan 24, 2020. It is now read-only.

PyPI release does not support Django 1.6 #3

Closed
jacobwegner opened this issue Mar 18, 2014 · 4 comments
Closed

PyPI release does not support Django 1.6 #3

jacobwegner opened this issue Mar 18, 2014 · 4 comments
Labels

Comments

@jacobwegner
Copy link

Hi. Thanks for a fantastic library!

Just wondering if you could push a new release to PyPI that works with Django 1.6. I'm just installing directly from the Github repo at the moment, but it'd be great to be able to pin to a new version on PyPI.

@Bouke
Copy link
Owner

Bouke commented Mar 19, 2014

Thank you. Can you provide information on why it doesn't install correctly? The pypi version is 0.4.0, same version as on GitHub, so it should just work.

@jacobwegner
Copy link
Author

Sure.

0.4.0 is at commit ff85847.

Beginning in Django 1.4, django.conf.urls.defaults was deprecated, but the defaults module was finally removed in Django 1.6

In commit 7fbf356 (after 0.4.0), urls.py was updated to import patterns and url from django.conf.urls:

-from django.conf.urls.defaults import patterns, url
+from django.conf.urls import patterns, url

@Bouke
Copy link
Owner

Bouke commented Mar 19, 2014

Ah yes, I see that the commit message is somewhat misleading. I'll update the package in a few days.

@Bouke
Copy link
Owner

Bouke commented Mar 23, 2014

I've pushed version 1.0 to Pypi, along with Python 3 support 😄. See: https://pypi.python.org/pypi/django-federated-login/1.0.0

@Bouke Bouke closed this as completed Mar 23, 2014
@Bouke Bouke added the question label Apr 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants