Fixed redirect_to after successful login #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouke
requested changes
Apr 11, 2017
There was a problem hiding this comment.
The changes in itself look good (as they are taken from upstream), however as these changes are adding functionality we'd also need some tests to make sure it keeps working as intended. See also the existing tests.
|
@Bouke I went ahead and added a |
Bouke
approved these changes
Apr 11, 2017
|
Nice work, thank you! |
|
No problem! When will you deploy this to PyPI? |
|
I have not date for it; as a deploy takes quite a bit of my free time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
redirect_towas not working correctly on a successful POST request login. I updated the logic to be consistent with how Django does it. See here as example to how Django handles gettingredirect_tofrom params.